From: Nguyễn Thái Ngọc Duy Date: Sun, 27 Dec 2015 01:51:32 +0000 (+0700) Subject: grep: make it clear i-t-a entries are ignored X-Git-Tag: v2.7.2~1^2 X-Git-Url: https://git.lorimer.id.au/gitweb.git/diff_plain/4d5520053 grep: make it clear i-t-a entries are ignored The expression "!S_ISREG(ce)" covers i-t-a entries as well because ce->ce_mode would be zero then. I could make a comment saying that, but it's probably better just to comment with code, in case i-t-a entry content changes in future. Signed-off-by: Nguyễn Thái Ngọc Duy Signed-off-by: Junio C Hamano --- diff --git a/builtin/grep.c b/builtin/grep.c index d04f4400d9..f508179740 100644 --- a/builtin/grep.c +++ b/builtin/grep.c @@ -375,7 +375,7 @@ static int grep_cache(struct grep_opt *opt, const struct pathspec *pathspec, int for (nr = 0; nr < active_nr; nr++) { const struct cache_entry *ce = active_cache[nr]; - if (!S_ISREG(ce->ce_mode)) + if (!S_ISREG(ce->ce_mode) || ce_intent_to_add(ce)) continue; if (!ce_path_match(ce, pathspec, NULL)) continue;