From: Alexander Gavrilov Date: Mon, 13 Oct 2008 08:12:33 +0000 (+0400) Subject: gitk: Implement batch lookup and caching of encoding attrs X-Git-Tag: v1.6.1-rc1~123^2~6 X-Git-Url: https://git.lorimer.id.au/gitweb.git/diff_plain/4db09304f97b12d7db5d199eebb1f24c74e12d17?ds=inline;hp=4db09304f97b12d7db5d199eebb1f24c74e12d17 gitk: Implement batch lookup and caching of encoding attrs When the diff contains thousands of files, calling git-check-attr once per file is very slow. With this patch gitk does attribute lookup in batches of 30 files while reading the diff file list, which leads to a very noticeable speedup. It may be possible to reimplement this even more efficiently, if git-check-attr is modified to support a --stdin-paths option. Additionally, it should quote the ':' character in file paths, or provide a more robust way of column separation. Signed-off-by: Alexander Gavrilov Tested-by: Johannes Sixt Signed-off-by: Paul Mackerras ---