From: Nguyễn Thái Ngọc Duy Date: Sun, 26 Mar 2017 02:42:16 +0000 (+0700) Subject: files-backend.c: delete dead code in files_ref_iterator_begin() X-Git-Tag: v2.13.0-rc0~9^2~25 X-Git-Url: https://git.lorimer.id.au/gitweb.git/diff_plain/4f43731268a85a095e6a0779fc94242f4694e0f4?ds=sidebyside files-backend.c: delete dead code in files_ref_iterator_begin() It's not in the diff context, but files_downcast() is called before this check. If "refs" is NULL, we would have segfaulted before reaching the check here. And we should never see NULL refs in backend code (frontend should have caught it). Signed-off-by: Nguyễn Thái Ngọc Duy Signed-off-by: Junio C Hamano --- diff --git a/refs/files-backend.c b/refs/files-backend.c index 42c0cc14f3..caeb8188fd 100644 --- a/refs/files-backend.c +++ b/refs/files-backend.c @@ -1897,9 +1897,6 @@ static struct ref_iterator *files_ref_iterator_begin( struct files_ref_iterator *iter; struct ref_iterator *ref_iterator; - if (!refs) - return empty_ref_iterator_begin(); - if (ref_paranoia < 0) ref_paranoia = git_env_bool("GIT_REF_PARANOIA", 0); if (ref_paranoia)