From: Junio C Hamano Date: Wed, 15 May 2019 01:42:35 +0000 (+0900) Subject: pkt-line: drop 'const'-ness of a param to set_packet_header() X-Git-Tag: v2.22.0-rc1~3^2 X-Git-Url: https://git.lorimer.id.au/gitweb.git/diff_plain/56bea280365238f0313f177b66fda6f87049d094?ds=inline;hp=--cc pkt-line: drop 'const'-ness of a param to set_packet_header() The function's definition has a paramter of type "int" qualified as "const". The fact that the incoming parameter is used as read-only in the fuction is an implementation detail that the callers should not have to be told in the prototype declaring it (and "const" there has no effect, as C passes parameters by value). The prototype defined for the function in pkt-line.h lacked the matching "const" for this reason, but apparently some compilers (e.g. MS Visual C 2017) complain about the parameter type mismatch. Let's squelch it by removing the "const" that is pointless in the definition of a small and trivial function like this, which would not help optimizing compilers nor reading humans that much. Noticed-by: Johannes Schindelin Helped-by: Jeff King Signed-off-by: Junio C Hamano --- 56bea280365238f0313f177b66fda6f87049d094 diff --git a/pkt-line.c b/pkt-line.c index c9ed780d0b..a0e87b1e81 100644 --- a/pkt-line.c +++ b/pkt-line.c @@ -119,7 +119,7 @@ void packet_buf_delim(struct strbuf *buf) strbuf_add(buf, "0001", 4); } -void set_packet_header(char *buf, const int size) +void set_packet_header(char *buf, int size) { static char hexchar[] = "0123456789abcdef";