From: SZEDER Gábor Date: Wed, 14 Nov 2012 00:49:30 +0000 (+0100) Subject: completion: remove 'help' duplicate from porcelain commands X-Git-Tag: v1.8.1-rc0~34^2 X-Git-Url: https://git.lorimer.id.au/gitweb.git/diff_plain/585b96bd4c55e587b7736063125d06bf46e39d18?ds=inline;hp=--cc completion: remove 'help' duplicate from porcelain commands The list of all git commands is computed from the output of 'git help -a', which already includes 'help', so there is no need to explicitly add it once more when computing the list of porcelain commands. Note that 'help' wasn't actually offered twice because of this, because Bash filters duplicates from possible completion words. Signed-off-by: SZEDER Gábor Signed-off-by: Junio C Hamano --- 585b96bd4c55e587b7736063125d06bf46e39d18 diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash index be800e09bd..5e23ec074b 100644 --- a/contrib/completion/git-completion.bash +++ b/contrib/completion/git-completion.bash @@ -585,7 +585,7 @@ __git_list_porcelain_commands () { local i IFS=" "$'\n' __git_compute_all_commands - for i in "help" $__git_all_commands + for i in $__git_all_commands do case $i in *--*) : helper pattern;;