From: İsmail Dönmez Date: Wed, 8 May 2019 11:30:58 +0000 (-0700) Subject: mingw: do not let ld strip relocations X-Git-Tag: v2.22.0-rc1~30^2~1 X-Git-Url: https://git.lorimer.id.au/gitweb.git/diff_plain/598b6c3a9270e7bd2379fc6084a6ddf694c0f8ea?ds=inline;hp=--cc mingw: do not let ld strip relocations This is the first step for enabling ASLR (Address Space Layout Randomization) support. We want to enable ASLR for better protection against exploiting security holes in Git: it makes it harder to attack software by making code addresses unpredictable. The problem fixed by this commit is that `ld.exe` seems to be stripping relocations which in turn will break ASLR support. We just make sure it's not stripping the main executable entry. Signed-off-by: İsmail Dönmez Signed-off-by: Johannes Schindelin Signed-off-by: Junio C Hamano --- 598b6c3a9270e7bd2379fc6084a6ddf694c0f8ea diff --git a/config.mak.uname b/config.mak.uname index d916d1dc7a..01b390c043 100644 --- a/config.mak.uname +++ b/config.mak.uname @@ -578,10 +578,12 @@ else ifeq (MINGW32,$(MSYSTEM)) prefix = /mingw32 HOST_CPU = i686 + BASIC_LDFLAGS += -Wl,--pic-executable,-e,_mainCRTStartup endif ifeq (MINGW64,$(MSYSTEM)) prefix = /mingw64 HOST_CPU = x86_64 + BASIC_LDFLAGS += -Wl,--pic-executable,-e,mainCRTStartup else COMPAT_CFLAGS += -D_USE_32BIT_TIME_T BASIC_LDFLAGS += -Wl,--large-address-aware