From: Jeff King <peff@peff.net>
Date: Thu, 24 May 2012 23:32:52 +0000 (-0400)
Subject: format-patch: do not use bogus email addresses in message ids
X-Git-Tag: v1.7.11-rc1~15^2
X-Git-Url: https://git.lorimer.id.au/gitweb.git/diff_plain/59f9b8a9a95cbcf4f6a5123cac04dc5073a8d0cc?ds=sidebyside;hp=-c

format-patch: do not use bogus email addresses in message ids

We can ask git_committer_info to be strict about coming up
with an email, which will die automatically on a poorly
configured machine. This is better than letting invalid
message-ids into the wild.

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---

59f9b8a9a95cbcf4f6a5123cac04dc5073a8d0cc
diff --git a/builtin/log.c b/builtin/log.c
index d86bca34dd..906dca475a 100644
--- a/builtin/log.c
+++ b/builtin/log.c
@@ -741,7 +741,7 @@ static void gen_message_id(struct rev_info *info, char *base)
 	struct strbuf buf = STRBUF_INIT;
 	strbuf_addf(&buf, "%s.%lu.git.%s", base,
 		    (unsigned long) time(NULL),
-		    git_committer_info(IDENT_NO_NAME|IDENT_NO_DATE));
+		    git_committer_info(IDENT_NO_NAME|IDENT_NO_DATE|IDENT_STRICT));
 	info->message_id = strbuf_detach(&buf, NULL);
 }