From: Michael Haggerty <mhagger@alum.mit.edu>
Date: Mon, 25 Apr 2016 09:58:23 +0000 (+0200)
Subject: ref_transaction_commit(): correctly report close_ref() failure
X-Git-Tag: v2.10.0-rc0~98^2~13
X-Git-Url: https://git.lorimer.id.au/gitweb.git/diff_plain/5a563d4ad17a66aabeacfd0f221ac45c07bc4ee8?ds=sidebyside

ref_transaction_commit(): correctly report close_ref() failure

Signed-off-by: Michael Haggerty <mhagger@alum.mit.edu>
---

diff --git a/refs/files-backend.c b/refs/files-backend.c
index 35d37ce58b..85e1e1c759 100644
--- a/refs/files-backend.c
+++ b/refs/files-backend.c
@@ -3139,6 +3139,7 @@ int ref_transaction_commit(struct ref_transaction *transaction,
 			if (close_ref(update->lock)) {
 				strbuf_addf(err, "couldn't close '%s.lock'",
 					    update->refname);
+				ret = TRANSACTION_GENERIC_ERROR;
 				goto cleanup;
 			}
 		}