From: Junio C Hamano Date: Thu, 1 Jun 2017 04:38:16 +0000 (+0900) Subject: diff- and log- family: handle "git cmd -h" early X-Git-Tag: v2.14.0-rc0~84^2~3 X-Git-Url: https://git.lorimer.id.au/gitweb.git/diff_plain/5a88f97cff0f269f8b2069b17c9da05ee66c98bb?hp=5a88f97cff0f269f8b2069b17c9da05ee66c98bb diff- and log- family: handle "git cmd -h" early "git $builtin -h" bypasses the usual repository setup and calls the cmd_$builtin() function, expecting it to show the help text. Unfortunately the commands in the log- and the diff- family want to call into the revisions machinery, which by definition needs to have a repository already discovered. Strictly speaking, they may not need a repository only for parsing "-h", but it is a good discipline to future-proof codepath to ensure that setup_revisions() is called after we know that a repository is there. Handle the "git $builtin -h" special case very early in these commands to work around potential issues. Signed-off-by: Junio C Hamano ---