From: Martin Ågren <martin.agren@gmail.com>
Date: Mon, 21 Aug 2017 17:43:45 +0000 (+0200)
Subject: convert: always initialize attr_action in convert_attrs
X-Git-Tag: v2.14.3~5^2~3
X-Git-Url: https://git.lorimer.id.au/gitweb.git/diff_plain/5c94c93d504e29c2099200a68926a34072cf2736?hp=5c94c93d504e29c2099200a68926a34072cf2736

convert: always initialize attr_action in convert_attrs

convert_attrs contains an "if-else". In the "if", we set attr_action
twice, and the first assignment has no effect. In the "else", we do not
set it at all. Since git_check_attr always returns the same value, we'll
always end up in the "if", so there is no problem right now. But
convert_attrs is obviously trying not to rely on such an
implementation-detail of another component.

Make the initialization of attr_action after the if-else. Remove the
earlier assignments.

Suggested-by: Torsten Bögershausen <tboegi@web.de>
Signed-off-by: Martin Ågren <martin.agren@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---