From: Ramsay Jones Date: Fri, 2 Mar 2018 02:56:05 +0000 (+0000) Subject: parse-options: remove the unused parse_opt_commits() function X-Git-Url: https://git.lorimer.id.au/gitweb.git/diff_plain/5cf69707386413d91436b8cf39e380592c830509?ds=inline;hp=--cc parse-options: remove the unused parse_opt_commits() function Commit fcfba37337 ('ref-filter: make "--contains " less chatty if is invalid', 2018-02-23), removed the last use of the callback function parse_opt_commits(). Remove this function declaration and definition, since it is now dead code. Signed-off-by: Ramsay Jones Reviewed-by: Jonathan Nieder Signed-off-by: Junio C Hamano --- 5cf69707386413d91436b8cf39e380592c830509 diff --git a/parse-options-cb.c b/parse-options-cb.c index c6679cb2cd..c7320a73f4 100644 --- a/parse-options-cb.c +++ b/parse-options-cb.c @@ -78,22 +78,6 @@ int parse_opt_verbosity_cb(const struct option *opt, const char *arg, return 0; } -int parse_opt_commits(const struct option *opt, const char *arg, int unset) -{ - struct object_id oid; - struct commit *commit; - - if (!arg) - return -1; - if (get_oid(arg, &oid)) - return error("malformed object name %s", arg); - commit = lookup_commit_reference(&oid); - if (!commit) - return error("no such commit %s", arg); - commit_list_insert(commit, opt->value); - return 0; -} - int parse_opt_object_name(const struct option *opt, const char *arg, int unset) { struct object_id oid; diff --git a/parse-options.h b/parse-options.h index 4b4734f2e7..2b8378ac1a 100644 --- a/parse-options.h +++ b/parse-options.h @@ -224,7 +224,6 @@ extern int parse_opt_expiry_date_cb(const struct option *, const char *, int); extern int parse_opt_color_flag_cb(const struct option *, const char *, int); extern int parse_opt_verbosity_cb(const struct option *, const char *, int); extern int parse_opt_object_name(const struct option *, const char *, int); -extern int parse_opt_commits(const struct option *, const char *, int); extern int parse_opt_tertiary(const struct option *, const char *, int); extern int parse_opt_string_list(const struct option *, const char *, int); extern int parse_opt_noop_cb(const struct option *, const char *, int);