From: Jeff King <peff@peff.net>
Date: Sun, 4 Nov 2018 02:27:46 +0000 (-0400)
Subject: midx: double-check large object write loop
X-Git-Tag: v2.20.0-rc0~23^2
X-Git-Url: https://git.lorimer.id.au/gitweb.git/diff_plain/61b0fcbb64d00d52290d433c1e754c01740b3d19?hp=61b0fcbb64d00d52290d433c1e754c01740b3d19

midx: double-check large object write loop

The write_midx_large_offsets() function takes an array of object
entries, the number of entries in the array (nr_objects), and the number
of entries with large offsets (nr_large_offset). But we never actually
use nr_objects; instead we keep walking down the array and counting down
nr_large_offset until we've seen all of the large entries.

This is correct, but we can be a bit more defensive. If there were ever
a mismatch between nr_large_offset and the actual set of large-offset
objects, we'd walk off the end of the array.

Since we know the size of the array, we can use nr_objects to make sure
we don't walk too far.

Signed-off-by: Jeff King <peff@peff.net>
Reviewed-by: Derrick Stolee <dstolee@microsoft.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---