From: Philippe Bruhat (BooK) <book@cpan.org>
Date: Thu, 17 Jun 2010 23:47:31 +0000 (+0200)
Subject: Git.pm: better error message
X-Git-Tag: v1.7.2-rc0~2^2
X-Git-Url: https://git.lorimer.id.au/gitweb.git/diff_plain/64abcc48447a976884e74a1efd866a21e06ddeec?ds=inline;hp=--cc

Git.pm: better error message

Provide the bad directory name alongside with $!

Note: $! is set if there is "No such file or directory",
but isn't set if the file exists but is not a directory.

Signed-off-by: Philippe Bruhat (BooK) <book@cpan.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---

64abcc48447a976884e74a1efd866a21e06ddeec
diff --git a/perl/Git.pm b/perl/Git.pm
index 1926dc9a4b..6cb0dd1934 100644
--- a/perl/Git.pm
+++ b/perl/Git.pm
@@ -172,7 +172,7 @@ sub repository {
 	}
 
 	if (defined $opts{Directory}) {
-		-d $opts{Directory} or throw Error::Simple("Directory not found: $!");
+		-d $opts{Directory} or throw Error::Simple("Directory not found: $opts{Directory} $!");
 
 		my $search = Git->repository(WorkingCopy => $opts{Directory});
 		my $dir;
@@ -545,7 +545,7 @@ sub wc_chdir {
 		or throw Error::Simple("bare repository");
 
 	-d $self->wc_path().'/'.$subdir
-		or throw Error::Simple("subdir not found: $!");
+		or throw Error::Simple("subdir not found: $subdir $!");
 	# Of course we will not "hold" the subdirectory so anyone
 	# can delete it now and we will never know. But at least we tried.