From: SZEDER Gábor Date: Mon, 17 Jun 2013 19:42:55 +0000 (+0200) Subject: bash prompt: avoid command substitution when finalizing gitstring X-Git-Tag: v1.8.4-rc0~97^2~1 X-Git-Url: https://git.lorimer.id.au/gitweb.git/diff_plain/69a8141a5d81925b7e08cb228535e9ea4a7a02e3 bash prompt: avoid command substitution when finalizing gitstring Before setting $PS1, __git_ps1() uses a command substitution to redirect the output from a printf into a variable. Spare the overhead of fork()ing a subshell by using 'printf -v ' to directly assign the output to that variable. zsh's printf doesn't support the '-v ' option, so stick with the command substitution when under zsh. Signed-off-by: SZEDER Gábor --- diff --git a/contrib/completion/git-prompt.sh b/contrib/completion/git-prompt.sh index 5ea6a68bc0..7152ae49fb 100644 --- a/contrib/completion/git-prompt.sh +++ b/contrib/completion/git-prompt.sh @@ -461,7 +461,11 @@ __git_ps1 () else gitstring="$c${b##refs/heads/}${f:+$z$f}$r$p" fi - gitstring=$(printf -- "$printf_format" "$gitstring") + if [[ -n ${ZSH_VERSION-} ]]; then + gitstring=$(printf -- "$printf_format" "$gitstring") + else + printf -v gitstring -- "$printf_format" "$gitstring" + fi PS1="$ps1pc_start$gitstring$ps1pc_end" else # NO color option unless in PROMPT_COMMAND mode