From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 30 Apr 2014 21:24:24 +0000 (-0700)
Subject: CodingGuidelines: give an example for redirection
X-Git-Tag: v2.1.0-rc0~151^2~6
X-Git-Url: https://git.lorimer.id.au/gitweb.git/diff_plain/6a49909b52b48592234da6a53bfe74ea34c302c6?ds=inline;hp=-c

CodingGuidelines: give an example for redirection

Signed-off-by: Junio C Hamano <gitster@pobox.com>
---

6a49909b52b48592234da6a53bfe74ea34c302c6
diff --git a/Documentation/CodingGuidelines b/Documentation/CodingGuidelines
index 169b4358c9..11704fb84c 100644
--- a/Documentation/CodingGuidelines
+++ b/Documentation/CodingGuidelines
@@ -61,6 +61,14 @@ For shell scripts specifically (not exhaustive):
    redirection target in a variable (as shown above), our code does so
    because some versions of bash issue a warning without the quotes.
 
+	(incorrect)
+	cat hello > world < universe
+	echo hello >$world
+
+	(correct)
+	cat hello >world <universe
+	echo hello >"$world"
+
  - We prefer $( ... ) for command substitution; unlike ``, it
    properly nests.  It should have been the way Bourne spelled
    it from day one, but unfortunately isn't.