From: René Scharfe <l.s.r@web.de>
Date: Wed, 24 Dec 2014 00:18:31 +0000 (+0100)
Subject: transport: simplify duplicating a substring in transport_get() using xmemdupz()
X-Git-Tag: v2.3.0-rc0~4^2
X-Git-Url: https://git.lorimer.id.au/gitweb.git/diff_plain/6b33894f9973185135a5ddd7d665c56bf5ca9a20?ds=inline;hp=--cc

transport: simplify duplicating a substring in transport_get() using xmemdupz()

Signed-off-by: Rene Scharfe <l.s.r@web.de>
Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---

6b33894f9973185135a5ddd7d665c56bf5ca9a20
diff --git a/transport.c b/transport.c
index 70d38e4c4b..08bcd3a4eb 100644
--- a/transport.c
+++ b/transport.c
@@ -971,9 +971,7 @@ struct transport *transport_get(struct remote *remote, const char *url)
 	} else {
 		/* Unknown protocol in URL. Pass to external handler. */
 		int len = external_specification_len(url);
-		char *handler = xmalloc(len + 1);
-		handler[len] = 0;
-		strncpy(handler, url, len);
+		char *handler = xmemdupz(url, len);
 		transport_helper_init(ret, handler);
 	}