From: Rene Scharfe <l.s.r@web.de>
Date: Wed, 30 Aug 2017 17:49:45 +0000 (+0200)
Subject: help: release strbuf on error return in exec_man_man()
X-Git-Tag: v2.15.0-rc0~78^2~20
X-Git-Url: https://git.lorimer.id.au/gitweb.git/diff_plain/7246218667635252395debc8eff2304592cbd587

help: release strbuf on error return in exec_man_man()

Signed-off-by: Rene Scharfe <l.s.r@web.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---

diff --git a/builtin/help.c b/builtin/help.c
index 991a8bb16c..12fb48933e 100644
--- a/builtin/help.c
+++ b/builtin/help.c
@@ -170,6 +170,7 @@ static void exec_man_cmd(const char *cmd, const char *page)
 	strbuf_addf(&shell_cmd, "%s %s", cmd, page);
 	execl(SHELL_PATH, SHELL_PATH, "-c", shell_cmd.buf, (char *)NULL);
 	warning(_("failed to exec '%s'"), cmd);
+	strbuf_release(&shell_cmd);
 }
 
 static void add_man_viewer(const char *name)