From: Andy Parkins <andyparkins@gmail.com>
Date: Tue, 13 Feb 2007 14:23:58 +0000 (+0000)
Subject: Fix potential command line overflow in hooks--update
X-Git-Tag: v1.5.0~6
X-Git-Url: https://git.lorimer.id.au/gitweb.git/diff_plain/72f627d2bc860c560e4ea4ee172982b1d38ceca8?ds=inline;hp=--cc

Fix potential command line overflow in hooks--update

In a repository with a large number of refs, the following command line
could easily overflow the command line size limitations

git-rev-list $newref $(git-rev-parse --not --all)

Fortunately, git-rev-list already has the means to cope with this
situation with the --stdin switch

git-rev-parse --not --all | git-rev-list --stdin $newref

Which is exactly what this patch does.

Signed-off-by: Andy Parkins <andyparkins@gmail.com>
Signed-off-by: Junio C Hamano <junkio@cox.net>
---

72f627d2bc860c560e4ea4ee172982b1d38ceca8
diff --git a/templates/hooks--update b/templates/hooks--update
index d4253cbcfb..e8c536fb61 100644
--- a/templates/hooks--update
+++ b/templates/hooks--update
@@ -148,7 +148,7 @@ case "$refname_type" in
 			# This shows all log entries that are not already covered by
 			# another ref - i.e. commits that are now accessible from this
 			# ref that were previously not accessible
-			git-rev-list --pretty $newref $(git-rev-parse --not --all)
+			git-rev-parse --not --all | git-rev-list --stdin --pretty $newref
 			echo $LOGEND
 		else
 			# oldrev is valid