From: Christian Couder Date: Wed, 11 Dec 2013 07:46:12 +0000 (+0100) Subject: builtin/replace: unset read_replace_refs X-Git-Tag: v1.9-rc0~41^2~2 X-Git-Url: https://git.lorimer.id.au/gitweb.git/diff_plain/769a4fa463bb36ba78eb318f25e0e211f4fae949 builtin/replace: unset read_replace_refs When checking to see if some objects are of the same type and when displaying the type of objects, git replace uses the sha1_object_info() function. Unfortunately this function by default respects replace refs, so instead of the type of a replaced object, it gives the type of the replacement object which might be different. To fix this bug, and because git replace should work at a level before replacement takes place, let's unset the read_replace_refs global variable at the beginning of cmd_replace(). Suggested-by: Jeff King Signed-off-by: Christian Couder Signed-off-by: Junio C Hamano --- diff --git a/builtin/replace.c b/builtin/replace.c index 9f3619a1bf..1672870e81 100644 --- a/builtin/replace.c +++ b/builtin/replace.c @@ -174,6 +174,8 @@ int cmd_replace(int argc, const char **argv, const char *prefix) OPT_END() }; + read_replace_refs = 0; + argc = parse_options(argc, argv, prefix, options, git_replace_usage, 0); if (list && delete) diff --git a/t/t6050-replace.sh b/t/t6050-replace.sh index e1cc3b89da..d0c62f7539 100755 --- a/t/t6050-replace.sh +++ b/t/t6050-replace.sh @@ -306,7 +306,7 @@ test_expect_success 'test --format medium' ' test_cmp expected actual ' -test_expect_failure 'test --format full' ' +test_expect_success 'test --format full' ' { echo "$H1 (commit) -> $BLOB (blob)" && echo "$BLOB (blob) -> $REPLACED (blob)" &&