From: Jeff King Date: Sat, 28 Sep 2013 08:32:02 +0000 (-0400) Subject: http: provide effective url to callers X-Git-Tag: v1.8.4.3~4^2~5 X-Git-Url: https://git.lorimer.id.au/gitweb.git/diff_plain/78868962c03e5bdddad5c5d02c1d5a0c72a7ac26?hp=--cc http: provide effective url to callers When we ask curl to access a URL, it may follow one or more redirects to reach the final location. We have no idea this has happened, as curl takes care of the details and simply returns the final content to us. The final URL that we ended up with can be accessed via CURLINFO_EFFECTIVE_URL. Let's make that optionally available to callers of http_get_*, so that they can make further decisions based on the redirection. Signed-off-by: Jeff King Signed-off-by: Jonathan Nieder --- 78868962c03e5bdddad5c5d02c1d5a0c72a7ac26 diff --git a/http.c b/http.c index 5703074d95..1569c56108 100644 --- a/http.c +++ b/http.c @@ -894,6 +894,10 @@ static int http_request(const char *url, curlinfo_strbuf(slot->curl, CURLINFO_CONTENT_TYPE, options->content_type); + if (options && options->effective_url) + curlinfo_strbuf(slot->curl, CURLINFO_EFFECTIVE_URL, + options->effective_url); + curl_slist_free_all(headers); strbuf_release(&buf); diff --git a/http.h b/http.h index 17116abc57..974ede7736 100644 --- a/http.h +++ b/http.h @@ -133,6 +133,12 @@ struct http_get_options { /* If non-NULL, returns the content-type of the response. */ struct strbuf *content_type; + + /* + * If non-NULL, returns the URL we ended up at, including any + * redirects we followed. + */ + struct strbuf *effective_url; }; /* Return values for http_get_*() */