From: Richard Lowe <richlowe@richlowe.net>
Date: Mon, 24 Feb 2014 00:54:47 +0000 (-0500)
Subject: diffcore.h: be explicit about the signedness of is_binary
X-Git-Tag: v2.0.0-rc0~101^2
X-Git-Url: https://git.lorimer.id.au/gitweb.git/diff_plain/7d0a9a752b66be76c4027ead98caa1be7bac5349

diffcore.h: be explicit about the signedness of is_binary

Bitfields need to specify their signedness explicitly or the compiler is
free to default as it sees fit.  With compilers that default 'unsigned'
(SUNWspro 12 seems to do this) the tri-state nature of is_binary
vanishes and all files are treated as binary.

Signed-off-by: Richard Lowe <richlowe@richlowe.net>
Acked-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---

diff --git a/diffcore.h b/diffcore.h
index 79de8cf28d..7c6f3916e8 100644
--- a/diffcore.h
+++ b/diffcore.h
@@ -46,7 +46,7 @@ struct diff_filespec {
 	unsigned is_stdin : 1;
 	unsigned has_more_entries : 1; /* only appear in combined diff */
 	/* data should be considered "binary"; -1 means "don't know yet" */
-	int is_binary : 2;
+	signed int is_binary : 2;
 	struct userdiff_driver *driver;
 };