From: Gary Gibbons Date: Wed, 4 Jul 2012 13:40:19 +0000 (-0400) Subject: git p4: refactor diffOpts calculation X-Git-Tag: v1.7.12-rc0~33^2~1 X-Git-Url: https://git.lorimer.id.au/gitweb.git/diff_plain/84cb00036fb59cf0ff305dcc27551f0519b5098c?hp=84cb00036fb59cf0ff305dcc27551f0519b5098c git p4: refactor diffOpts calculation P4Submit.applyCommit() To avoid recalculating the same diffOpts for each commit, move it out of applyCommit() and into the top-level run(). Also fix a bug in that code which interpreted the value of detectRenames as a string rather than as a boolean. [pw: fix documentation, rearrange code a bit] Signed-off-by: Gary Gibbons Signed-off-by: Pete Wyckoff Signed-off-by: Junio C Hamano ---