From: Junio C Hamano <gitster@pobox.com>
Date: Fri, 13 Feb 2015 20:20:25 +0000 (-0800)
Subject: send-email: ask confirmation if given encoding name is very short
X-Git-Tag: v2.4.0-rc0~84^2
X-Git-Url: https://git.lorimer.id.au/gitweb.git/diff_plain/852a15d748034eec87adbee73a72689c8936fb8b?hp=--cc

send-email: ask confirmation if given encoding name is very short

Sometimes people respond "y<ENTER>" (or "yes<ENTER>") when asked
this question:

Which 8bit encoding should I declare [UTF-8]?

We already have a mechanism to avoid accepting a mistyped e-mail
address (we ask to confirm when the given address lacks "@" in it);
reuse it to trigger the same confirmation when given a very short
answer.  As a typical charset name is probably at least 4 chars or
longer (e.g. "UTF8" spelled without the dash, or "Big5"), this would
prevent such a mistake.

Signed-off-by: Junio C Hamano <gitster@pobox.com>
---

852a15d748034eec87adbee73a72689c8936fb8b
diff --git a/git-send-email.perl b/git-send-email.perl
index fdb0029b59..eb32371151 100755
--- a/git-send-email.perl
+++ b/git-send-email.perl
@@ -733,6 +733,7 @@ sub file_declares_8bit_cte {
 		print "    $f\n";
 	}
 	$auto_8bit_encoding = ask("Which 8bit encoding should I declare [UTF-8]? ",
+				  valid_re => qr/.{4}/, confirm_only => 1,
 				  default => "UTF-8");
 }