From: Linus Torvalds <torvalds@g5.osdl.org>
Date: Thu, 14 Jul 2005 02:40:06 +0000 (-0700)
Subject: git-fetch-pack: close output fd after dup'ing the input
X-Git-Tag: v0.99.1~40
X-Git-Url: https://git.lorimer.id.au/gitweb.git/diff_plain/85c414b5e05d2087e779cdd3587d6ad4cae56e72

git-fetch-pack: close output fd after dup'ing the input

With the socket case, the input and output fd's might end up being the same,
so we want to dup the other before we close either of them.
---

diff --git a/fetch-pack.c b/fetch-pack.c
index ec5bad89cd..3475ea380a 100644
--- a/fetch-pack.c
+++ b/fetch-pack.c
@@ -95,9 +95,9 @@ static int fetch_pack(int fd[2], int nr_match, char **match)
 	if (pid < 0)
 		die("git-fetch-pack: unable to fork off git-unpack-objects");
 	if (!pid) {
-		close(fd[1]);
 		dup2(fd[0], 0);
 		close(fd[0]);
+		close(fd[1]);
 		execlp("git-unpack-objects", "git-unpack-objects", NULL);
 		die("git-unpack-objects exec failed");
 	}