From: Jeff King <peff@peff.net>
Date: Sun, 17 Aug 2014 07:35:53 +0000 (-0400)
Subject: http: style fixes for curl_multi_init error check
X-Git-Tag: v2.2.0-rc0~144^2
X-Git-Url: https://git.lorimer.id.au/gitweb.git/diff_plain/8837eb47f27665450c898affc39816c48edacd80?hp=--cc

http: style fixes for curl_multi_init error check

Unless there is a good reason, we should use die() rather than
fprintf/exit. We can also shorten the message to match other curl init
failures (and match our usual lowercase no-full-stop style).

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---

8837eb47f27665450c898affc39816c48edacd80
diff --git a/http.c b/http.c
index 0276aa9426..d33b122cd1 100644
--- a/http.c
+++ b/http.c
@@ -421,10 +421,8 @@ void http_init(struct remote *remote, const char *url, int proactive_auth)
 	}
 
 	curlm = curl_multi_init();
-	if (curlm == NULL) {
-		fprintf(stderr, "Error creating curl multi handle.\n");
-		exit(1);
-	}
+	if (!curlm)
+		die("curl_multi_init failed");
 #endif
 
 	if (getenv("GIT_SSL_NO_VERIFY"))