From: Junio C Hamano Date: Thu, 4 Jan 2007 07:09:08 +0000 (-0800) Subject: pack-check.c::verify_packfile(): don't run SHA-1 update on huge data X-Git-Tag: v1.4.4.4^0 X-Git-Url: https://git.lorimer.id.au/gitweb.git/diff_plain/8977c110b5bbd230c28c727ddb85856067d55cfb?hp=8977c110b5bbd230c28c727ddb85856067d55cfb pack-check.c::verify_packfile(): don't run SHA-1 update on huge data Running the SHA1_Update() on the whole packfile in a single call revealed an overflow problem we had in the SHA-1 implementation on POWER architecture some time ago, which was fixed with commit b47f509b (June 19, 2006). Other SHA-1 implementations may have a similar problem. The sliding mmap() series already makes chunked calls to SHA1_Update(), so this patch itself will become moot when it graduates to "master", but in the meantime, run the hash function in smaller chunks to prevent possible future problems. Signed-off-by: Junio C Hamano ---