From: Felipe Contreras <felipe.contreras@gmail.com>
Date: Tue, 7 May 2013 21:55:03 +0000 (-0500)
Subject: tests: at-combinations: improve nonsense()
X-Git-Tag: v1.8.4-rc0~180^2~10
X-Git-Url: https://git.lorimer.id.au/gitweb.git/diff_plain/89d5dd4e2f47186687d70223847cec8ec3fb16dd

tests: at-combinations: improve nonsense()

In some circumstances 'git log' might fail, but not because the @
parsing failed. For example: 'git rev-parse' might succeed and return a
bad object, and then 'git log' would fail.

The layer we want to test is revision parsing, so let's test that
directly.

Signed-off-by: Ramkumar Ramachandra <artagnon@gmail.com>
Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---

diff --git a/t/t1508-at-combinations.sh b/t/t1508-at-combinations.sh
index 1126125672..d45a410362 100755
--- a/t/t1508-at-combinations.sh
+++ b/t/t1508-at-combinations.sh
@@ -18,7 +18,7 @@ check() {
 
 nonsense() {
 	test_expect_${2:-success} "$1 is nonsensical" "
-		test_must_fail git log -1 '$1'
+		test_must_fail git rev-parse --verify '$1'
 	"
 }