From: Matthew DeVore <matvore@google.com>
Date: Fri, 5 Oct 2018 21:54:07 +0000 (-0700)
Subject: tests: order arguments to git-rev-list properly
X-Git-Tag: v2.20.0-rc0~183^2
X-Git-Url: https://git.lorimer.id.au/gitweb.git/diff_plain/8d6ba49563600d8e65c7f56fb0f29e23a571a75f?ds=inline;hp=8d6ba49563600d8e65c7f56fb0f29e23a571a75f

tests: order arguments to git-rev-list properly

It is a common mistake to put positional arguments before flags when
invoking git-rev-list. Order the positional arguments last.

This patch skips git-rev-list invocations which include the --not flag,
since the ordering of flags and positional arguments affects the
behavior. This patch also skips invocations of git-rev-list that occur
in command substitution in which the exit code is discarded, since
fixing those properly will require a more involved cleanup.

Signed-off-by: Matthew DeVore <matvore@google.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---