From: Lars Gullik Bjønnes Date: Sat, 15 Feb 2014 17:24:50 +0000 (+0100) Subject: git-contacts: do not fail parsing of good diffs X-Git-Tag: v2.0.0-rc0~128^2 X-Git-Url: https://git.lorimer.id.au/gitweb.git/diff_plain/8f72011f1c4a626ed1c1e826661d42274f465e29 git-contacts: do not fail parsing of good diffs If a line in a patch starts with "--- " it will be deemed malformed unless it also contains the proper diff header format. This situation can happen with a valid patch if it has a line starting with "-- " and that line is removed. This patch just removes the check in git-contacts. Signed-off-by: Lars Gullik Bjønnes Signed-off-by: Junio C Hamano --- diff --git a/contrib/contacts/git-contacts b/contrib/contacts/git-contacts index 428cc1a9a1..dbe2abf277 100755 --- a/contrib/contacts/git-contacts +++ b/contrib/contacts/git-contacts @@ -96,8 +96,6 @@ sub scan_patches { next unless $id; if (m{^--- (?:a/(.+)|/dev/null)$}) { $source = $1; - } elsif (/^--- /) { - die "Cannot parse hunk source: $_\n"; } elsif (/^@@ -(\d+)(?:,(\d+))?/ && $source) { my $len = defined($2) ? $2 : 1; push @{$sources->{$source}{$id}}, [$1, $len] if $len;