From: Jeff King Date: Mon, 19 Feb 2018 19:50:14 +0000 (-0500) Subject: remote-curl: unquote incoming push-options X-Git-Tag: v2.17.0-rc0~52^2 X-Git-Url: https://git.lorimer.id.au/gitweb.git/diff_plain/90dce21eb0fcf28096e661a3dd3b4e93fa0bccb5?hp=90dce21eb0fcf28096e661a3dd3b4e93fa0bccb5 remote-curl: unquote incoming push-options The transport-helper protocol c-style quotes the value of any options passed to the helper via the "option " directive. However, remote-curl doesn't actually unquote the push-option values, meaning that we will send the quoted version to the other side (whereas git-over-ssh would send the raw value). The pack-protocol.txt documentation defines the push-options as a series of VCHARs, which excludes most characters that would need quoting. But: 1. You can still see the bug with a valid push-option that starts with a double-quote (since that triggers quoting). 2. We do currently handle any non-NUL characters correctly in git-over-ssh. So even though the spec does not say that we need to handle most quoted characters, it's nice if our behavior is consistent between protocols. There are two new tests: the "direct" one shows that this already works in the non-http case, and the http one covers this bugfix. Reported-by: Jon Simons Signed-off-by: Jeff King Signed-off-by: Junio C Hamano ---