From: Jeff King <peff@peff.net>
Date: Fri, 21 Oct 2016 10:42:10 +0000 (-0400)
Subject: test-lib: handle TEST_OUTPUT_DIRECTORY with spaces
X-Git-Tag: v2.10.2~8^2~3
X-Git-Url: https://git.lorimer.id.au/gitweb.git/diff_plain/925bdc928e3debdc6dbf28b5648711eb1c5583d3?hp=--cc

test-lib: handle TEST_OUTPUT_DIRECTORY with spaces

We are careful in test_done to handle a results directory
with a space in it, but the "--tee" code path does not.
Doing:

export TEST_OUTPUT_DIRECTORY='/tmp/path with spaces'
./t000-init.sh --tee

results in errors. Let's consistently double-quote our path
variables so that this works.

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---

925bdc928e3debdc6dbf28b5648711eb1c5583d3
diff --git a/t/test-lib.sh b/t/test-lib.sh
index 39c70f0326..01bb58ef00 100644
--- a/t/test-lib.sh
+++ b/t/test-lib.sh
@@ -58,8 +58,8 @@ done,*)
 	mkdir -p "$TEST_OUTPUT_DIRECTORY/test-results"
 	BASE="$TEST_OUTPUT_DIRECTORY/test-results/$(basename "$0" .sh)"
 	(GIT_TEST_TEE_STARTED=done ${SHELL_PATH} "$0" "$@" 2>&1;
-	 echo $? > $BASE.exit) | tee $BASE.out
-	test "$(cat $BASE.exit)" = 0
+	 echo $? >"$BASE.exit") | tee "$BASE.out"
+	test "$(cat "$BASE.exit")" = 0
 	exit
 	;;
 esac