From: Junio C Hamano Date: Mon, 25 Sep 2017 06:24:09 +0000 (+0900) Subject: Merge branch 'rj/test-ulimit-on-windows' X-Git-Tag: v2.15.0-rc0~54 X-Git-Url: https://git.lorimer.id.au/gitweb.git/diff_plain/9709ffac8004c3dc62dc946af469ec6d69bfeffb?hp=-c Merge branch 'rj/test-ulimit-on-windows' On Cygwin, "ulimit -s" does not report failure but it does not work at all, which causes an unexpected success of some tests that expect failures under a limited stack situation. This has been fixed. * rj/test-ulimit-on-windows: t9010-*.sh: skip all tests if the PIPE prereq is missing test-lib: use more compact expression in PIPE prerequisite test-lib: don't use ulimit in test prerequisites on cygwin --- 9709ffac8004c3dc62dc946af469ec6d69bfeffb diff --combined t/test-lib.sh index 83f5d3dd21,c730c0bc13..9b61f16f7a --- a/t/test-lib.sh +++ b/t/test-lib.sh @@@ -44,11 -44,6 +44,11 @@@ GIT_BUILD_DIR="$TEST_DIRECTORY"/. : ${ASAN_OPTIONS=detect_leaks=0:abort_on_error=1} export ASAN_OPTIONS +# If LSAN is in effect we _do_ want leak checking, but we still +# want to abort so that we notice the problems. +: ${LSAN_OPTIONS=abort_on_error=1} +export LSAN_OPTIONS + ################################################################ # It appears that people try to run tests without building... "$GIT_BUILD_DIR/git" >/dev/null @@@ -279,7 -274,7 +279,7 @@@ the test -z "$verbose" && verbose_only="$valgrind_only" elif test -n "$valgrind" then - verbose=t + test -z "$verbose_log" && verbose=t fi if test -n "$color" @@@ -1067,14 -1062,8 +1067,8 @@@ test_i18ngrep () test_lazy_prereq PIPE ' # test whether the filesystem supports FIFOs - case $(uname -s) in - CYGWIN*|MINGW*) - false - ;; - *) - rm -f testfifo && mkfifo testfifo - ;; - esac + test_have_prereq !MINGW,!CYGWIN && + rm -f testfifo && mkfifo testfifo ' test_lazy_prereq SYMLINKS ' @@@ -1170,13 -1159,19 +1164,19 @@@ run_with_limited_cmdline () (ulimit -s 128 && "$@") } - test_lazy_prereq CMDLINE_LIMIT 'run_with_limited_cmdline true' + test_lazy_prereq CMDLINE_LIMIT ' + test_have_prereq !MINGW,!CYGWIN && + run_with_limited_cmdline true + ' run_with_limited_stack () { (ulimit -s 128 && "$@") } - test_lazy_prereq ULIMIT_STACK_SIZE 'run_with_limited_stack true' + test_lazy_prereq ULIMIT_STACK_SIZE ' + test_have_prereq !MINGW,!CYGWIN && + run_with_limited_stack true + ' build_option () { git version --build-options |