From: Ben Peart <peartben@gmail.com>
Date: Fri, 5 May 2017 15:27:54 +0000 (-0400)
Subject: pkt-line: fix packet_read_line() to handle len < 0 errors
X-Git-Tag: v2.14.0-rc0~144^2~9
X-Git-Url: https://git.lorimer.id.au/gitweb.git/diff_plain/974b50c5565107e1e3209176682ee6f6e420bd2b

pkt-line: fix packet_read_line() to handle len < 0 errors

Update packet_read_line() to test for len > 0 to avoid potential bug
if read functions return lengths less than zero to indicate errors.

Signed-off-by: Ben Peart <benpeart@microsoft.com>
Found/Fixed-by: Lars Schneider <larsxschneider@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---

diff --git a/pkt-line.c b/pkt-line.c
index d4b6bfe076..6f05b1a4a8 100644
--- a/pkt-line.c
+++ b/pkt-line.c
@@ -315,7 +315,7 @@ static char *packet_read_line_generic(int fd,
 			      PACKET_READ_CHOMP_NEWLINE);
 	if (dst_len)
 		*dst_len = len;
-	return len ? packet_buffer : NULL;
+	return (len > 0) ? packet_buffer : NULL;
 }
 
 char *packet_read_line(int fd, int *len_p)