From: Matthew DeVore Date: Fri, 5 Oct 2018 21:31:24 +0000 (-0700) Subject: revision: mark non-user-given objects instead X-Git-Tag: v2.20.0-rc0~129^2~5 X-Git-Url: https://git.lorimer.id.au/gitweb.git/diff_plain/99c9aa9579ae970c0d273ced8fb8efe9eed70a75?hp=99c9aa9579ae970c0d273ced8fb8efe9eed70a75 revision: mark non-user-given objects instead Currently, list-objects.c incorrectly treats all root trees of commits as USER_GIVEN. Also, it would be easier to mark objects that are non-user-given instead of user-given, since the places in the code where we access an object through a reference are more obvious than the places where we access an object that was given by the user. Resolve these two problems by introducing a flag NOT_USER_GIVEN that marks blobs and trees that are non-user-given, replacing USER_GIVEN. (Only blobs and trees are marked because this mark is only used when filtering objects, and filtering of other types of objects is not supported yet.) This fixes a bug in that git rev-list behaved differently from git pack-objects. pack-objects would *not* filter objects given explicitly on the command line and rev-list would filter. This was because the two commands used a different function to add objects to the rev_info struct. This seems to have been an oversight, and pack-objects has the correct behavior, so I added a test to make sure that rev-list now behaves properly. Signed-off-by: Matthew DeVore Signed-off-by: Junio C Hamano ---