From: Jeff King Date: Wed, 20 Mar 2019 08:16:42 +0000 (-0400) Subject: pretty: drop unused strbuf from parse_padding_placeholder() X-Git-Tag: v2.22.0-rc0~72^2~1 X-Git-Url: https://git.lorimer.id.au/gitweb.git/diff_plain/9a1180fc304ad9831641e5788e9c8d3dfc10ccdd?ds=inline;hp=--cc pretty: drop unused strbuf from parse_padding_placeholder() Unlike other parts of the --pretty user-format expansion, this function is not actually writing to the output, but instead just storing the padding values into a context struct. We don't need to be passed a strbuf at all. Signed-off-by: Jeff King Signed-off-by: Junio C Hamano --- 9a1180fc304ad9831641e5788e9c8d3dfc10ccdd diff --git a/pretty.c b/pretty.c index f925a014f9..ced0485257 100644 --- a/pretty.c +++ b/pretty.c @@ -988,8 +988,7 @@ static size_t parse_color(struct strbuf *sb, /* in UTF-8 */ return rest - placeholder; } -static size_t parse_padding_placeholder(struct strbuf *sb, - const char *placeholder, +static size_t parse_padding_placeholder(const char *placeholder, struct format_commit_context *c) { const char *ch = placeholder; @@ -1194,7 +1193,7 @@ static size_t format_commit_one(struct strbuf *sb, /* in UTF-8 */ case '<': case '>': - return parse_padding_placeholder(sb, placeholder, c); + return parse_padding_placeholder(placeholder, c); } /* these depend on the commit */