From: Junio C Hamano <gitster@pobox.com>
Date: Fri, 15 Aug 2014 17:02:46 +0000 (-0700)
Subject: config.mak.uname: add hint on uname_R for MacOS X
X-Git-Tag: v2.2.0-rc0~156^2
X-Git-Url: https://git.lorimer.id.au/gitweb.git/diff_plain/9eeff2f6810d4f962aa78ddf43193fba26d9451a?ds=inline;hp=--cc

config.mak.uname: add hint on uname_R for MacOS X

I always have to scratch my head every time I see this cryptic
pattern "[15678]\."; leave a short note to remind the maintainer
and the reviewers.

Signed-off-by: Junio C Hamano <gitster@pobox.com>
---

9eeff2f6810d4f962aa78ddf43193fba26d9451a
diff --git a/config.mak.uname b/config.mak.uname
index f8e12c9626..fde196f63a 100644
--- a/config.mak.uname
+++ b/config.mak.uname
@@ -86,6 +86,10 @@ ifeq ($(uname_S),Darwin)
 	NEEDS_CRYPTO_WITH_SSL = YesPlease
 	NEEDS_SSL_WITH_CRYPTO = YesPlease
 	NEEDS_LIBICONV = YesPlease
+	# Note: $(uname_R) gives us the underlying Darwin version.
+	# - MacOS 10.0.* and MacOS 10.1.0 = Darwin 1.*
+	# - MacOS 10.x.* = Darwin (x+4).* for (1 <= x)
+	# i.e. "begins with [15678] and a dot" means "10.4.* or older".
 	ifeq ($(shell expr "$(uname_R)" : '[15678]\.'),2)
 		OLD_ICONV = UnfortunatelyYes
 		NO_APPLE_COMMON_CRYPTO = YesPlease