From: Stefan Naewe Date: Sat, 5 Dec 2015 15:27:24 +0000 (+0100) Subject: revision.c: fix possible null pointer arithmetic X-Git-Tag: v2.7.0-rc1~8^2 X-Git-Url: https://git.lorimer.id.au/gitweb.git/diff_plain/a2678df335f3404bc5d96683fa36b8cfab7946b0 revision.c: fix possible null pointer arithmetic mark_tree_uninteresting() dereferences a tree pointer before checking if the pointer is valid. Fix that by doing the check first. Signed-off-by: Stefan Naewe Signed-off-by: Junio C Hamano --- diff --git a/revision.c b/revision.c index 9b9d77dc43..7f4acad456 100644 --- a/revision.c +++ b/revision.c @@ -131,10 +131,12 @@ static void mark_tree_contents_uninteresting(struct tree *tree) void mark_tree_uninteresting(struct tree *tree) { - struct object *obj = &tree->object; + struct object *obj; if (!tree) return; + + obj = &tree->object; if (obj->flags & UNINTERESTING) return; obj->flags |= UNINTERESTING;