From: Jeff King <peff@peff.net>
Date: Sun, 24 Mar 2019 12:08:38 +0000 (-0400)
Subject: http: factor out curl result code normalization
X-Git-Tag: v2.22.0-rc0~94^2~2
X-Git-Url: https://git.lorimer.id.au/gitweb.git/diff_plain/a3722bcbbd850bf02aea19d58de112ef513cb2f1?hp=a3722bcbbd850bf02aea19d58de112ef513cb2f1

http: factor out curl result code normalization

We make some requests with CURLOPT_FAILONERROR and some without, and
then handle_curl_result() normalizes any failures to a uniform CURLcode.

There are some other code paths in the dumb-http walker which don't use
handle_curl_result(); let's pull the normalization into its own function
so it can be reused.

Arguably those code paths would benefit from the rest of
handle_curl_result(), notably the auth handling. But retro-fitting it
now would be a lot of work, and in practice it doesn't matter too much
(whatever authentication we needed to make the initial contact with the
server is generally sufficient for the rest of the dumb-http requests).

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---