From: Jeff King <peff@peff.net>
Date: Sat, 15 Dec 2012 17:42:10 +0000 (-0500)
Subject: silence some -Wuninitialized false positives
X-Git-Tag: v1.8.2-rc0~179^2
X-Git-Url: https://git.lorimer.id.au/gitweb.git/diff_plain/a469a1019352b8efc4bd7003b0bd59eb60fc428c?ds=inline;hp=a469a1019352b8efc4bd7003b0bd59eb60fc428c

silence some -Wuninitialized false positives

There are a few error functions that simply wrap error() and
provide a standardized message text. Like error(), they
always return -1; knowing that can help the compiler silence
some false positive -Wuninitialized warnings.

One strategy would be to just declare these as inline in the
header file so that the compiler can see that they always
return -1. However, gcc does not always inline them (e.g.,
it will not inline opterror, even with -O3), which renders
our change pointless.

Instead, let's follow the same route we did with error() in
the last patch, and define a macro that makes the constant
return value obvious to the compiler.

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---