From: Jeff King Date: Wed, 14 Feb 2018 18:08:57 +0000 (-0500) Subject: test-hashmap: use "unsigned int" for hash storage X-Git-Tag: v2.17.0-rc0~64^2 X-Git-Url: https://git.lorimer.id.au/gitweb.git/diff_plain/a6119f82b118c7adea9ede0b3813810b06e37668 test-hashmap: use "unsigned int" for hash storage The hashmap API always use an unsigned value for storing and comparing hashes. Whereas this test code uses "int". This works out in practice since one can typically round-trip between "int" and "unsigned int". But since this is essentially reference code for the hashmap API, we should model using the correct types. Signed-off-by: Jeff King Signed-off-by: Junio C Hamano --- diff --git a/t/helper/test-hashmap.c b/t/helper/test-hashmap.c index 56efff36e8..9ae9281c07 100644 --- a/t/helper/test-hashmap.c +++ b/t/helper/test-hashmap.c @@ -30,7 +30,8 @@ static int test_entry_cmp(const void *cmp_data, return strcmp(e1->key, key ? key : e2->key); } -static struct test_entry *alloc_test_entry(int hash, char *key, char *value) +static struct test_entry *alloc_test_entry(unsigned int hash, + char *key, char *value) { size_t klen = strlen(key); size_t vlen = strlen(value); @@ -156,7 +157,7 @@ int cmd_main(int argc, const char **argv) /* process commands from stdin */ while (strbuf_getline(&line, stdin) != EOF) { char *cmd, *p1 = NULL, *p2 = NULL; - int hash = 0; + unsigned int hash = 0; struct test_entry *entry; /* break line into command and up to two parameters */