From: Thomas Rast <trast@inf.ethz.ch>
Date: Fri, 12 Jul 2013 08:58:36 +0000 (+0200)
Subject: run-command: dup_devnull(): guard against syscalls failing
X-Git-Tag: v1.8.4-rc0~35^2
X-Git-Url: https://git.lorimer.id.au/gitweb.git/diff_plain/a77f106c7837faf6a712ea3ac720f5c4fa2feb07

run-command: dup_devnull(): guard against syscalls failing

dup_devnull() did not check the return values of open() and dup2().
Fix this omission.

Signed-off-by: Thomas Rast <trast@inf.ethz.ch>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---

diff --git a/run-command.c b/run-command.c
index 04712191e8..afc573ed41 100644
--- a/run-command.c
+++ b/run-command.c
@@ -76,7 +76,10 @@ static inline void close_pair(int fd[2])
 static inline void dup_devnull(int to)
 {
 	int fd = open("/dev/null", O_RDWR);
-	dup2(fd, to);
+	if (fd < 0)
+		die_errno(_("open /dev/null failed"));
+	if (dup2(fd, to) < 0)
+		die_errno(_("dup2(%d,%d) failed"), fd, to);
 	close(fd);
 }
 #endif