From: Kevin Ballard Date: Wed, 3 Nov 2010 06:26:24 +0000 (-0700) Subject: submodule: preserve all arguments exactly when recursing X-Git-Tag: v1.7.4-rc0~128^2~1 X-Git-Url: https://git.lorimer.id.au/gitweb.git/diff_plain/a7eff1a87ad8cdcb93f60efc7969042bc3e669ee?ds=inline;hp=a7eff1a87ad8cdcb93f60efc7969042bc3e669ee submodule: preserve all arguments exactly when recursing Shell variables only hold strings, not lists of parameters, so $orig_args after orig_args="$@" fails to remember where each parameter starts and ends, if some include whitespace. So git submodule update \ --reference='/var/lib/common objects.git' \ --recursive --init becomes git submodule update --reference=/var/lib/common \ objects.git --recursive --init in the inner repositories. Use "git rev-parse --sq-quote" to save parameters in quoted form ready for evaluation by the shell, avoiding this problem. Helped-By: Jonathan Nieder Signed-off-by: Kevin Ballard Signed-off-by: Junio C Hamano ---