From: Andreas Gruenbacher <agruen@suse.de>
Date: Sat, 13 Mar 2010 17:17:04 +0000 (+0100)
Subject: fetch: Check for a "^{}" suffix with suffixcmp()
X-Git-Tag: v1.7.0.3~6
X-Git-Url: https://git.lorimer.id.au/gitweb.git/diff_plain/aac1d7b88918f39b1b7c5bc0dcf831dcc9d5d8a8?ds=inline;hp=--cc

fetch: Check for a "^{}" suffix with suffixcmp()

Otherwise, we will check random bytes for ref names < 3 characters.

Signed-off-by: Andreas Gruenbacher <agruen@suse.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---

aac1d7b88918f39b1b7c5bc0dcf831dcc9d5d8a8
diff --git a/builtin-fetch.c b/builtin-fetch.c
index b059d652c6..0acf80991b 100644
--- a/builtin-fetch.c
+++ b/builtin-fetch.c
@@ -588,7 +588,7 @@ static void find_non_local_tags(struct transport *transport,
 		 * to fetch then we can mark the ref entry in the list
 		 * as one to ignore by setting util to NULL.
 		 */
-		if (!strcmp(ref->name + strlen(ref->name) - 3, "^{}")) {
+		if (!suffixcmp(ref->name, "^{}")) {
 			if (item && !has_sha1_file(ref->old_sha1) &&
 			    !will_fetch(head, ref->old_sha1) &&
 			    !has_sha1_file(item->util) &&