From: Jeff King Date: Thu, 24 Sep 2015 21:05:45 +0000 (-0400) Subject: add reentrant variants of sha1_to_hex and find_unique_abbrev X-Git-Tag: v2.8.3~32^2~19 X-Git-Url: https://git.lorimer.id.au/gitweb.git/diff_plain/af49c6d0918bf04aad89bd885a4eef5767a33d0e?hp=af49c6d0918bf04aad89bd885a4eef5767a33d0e add reentrant variants of sha1_to_hex and find_unique_abbrev The sha1_to_hex and find_unique_abbrev functions always write into reusable static buffers. There are a few problems with this: - future calls overwrite our result. This is especially annoying with find_unique_abbrev, which does not have a ring of buffers, so you cannot even printf() a result that has two abbreviated sha1s. - if you want to put the result into another buffer, we often strcpy, which looks suspicious when auditing for overflows. This patch introduces sha1_to_hex_r and find_unique_abbrev_r, which write into a user-provided buffer. Of course this is just punting on the overflow-auditing, as the buffer obviously needs to be GIT_SHA1_HEXSZ + 1 bytes. But it is much easier to audit, since that is a well-known size. We retain the non-reentrant forms, which just become thin wrappers around the reentrant ones. This patch also adds a strbuf variant of find_unique_abbrev, which will be handy in later patches. Signed-off-by: Jeff King Signed-off-by: Junio C Hamano ---