From: Ramsay Jones Date: Thu, 9 Jun 2016 22:52:22 +0000 (+0100) Subject: write_or_die: remove the unused write_or_whine() function X-Git-Tag: v2.9.3~35^2 X-Git-Url: https://git.lorimer.id.au/gitweb.git/diff_plain/b333d0d6f450d4f9c4535fd9fd6e0f4ef367507c write_or_die: remove the unused write_or_whine() function Now the last caller of this function is gone, and new ones are unlikely to appear, because this function is doing very little that a regular if() does not besides obfuscating the error message (and if we ever did want something like it, we would probably prefer the function to come back with more "normal" return value semantics). Signed-off-by: Ramsay Jones Signed-off-by: Junio C Hamano --- diff --git a/cache.h b/cache.h index 4ff196c259..5e5c1df1a7 100644 --- a/cache.h +++ b/cache.h @@ -1715,7 +1715,6 @@ extern int copy_file(const char *dst, const char *src, int mode); extern int copy_file_with_time(const char *dst, const char *src, int mode); extern void write_or_die(int fd, const void *buf, size_t count); -extern int write_or_whine(int fd, const void *buf, size_t count, const char *msg); extern int write_or_whine_pipe(int fd, const void *buf, size_t count, const char *msg); extern void fsync_or_die(int fd, const char *); diff --git a/write_or_die.c b/write_or_die.c index 49e80aa222..981687945a 100644 --- a/write_or_die.c +++ b/write_or_die.c @@ -94,14 +94,3 @@ int write_or_whine_pipe(int fd, const void *buf, size_t count, const char *msg) return 1; } - -int write_or_whine(int fd, const void *buf, size_t count, const char *msg) -{ - if (write_in_full(fd, buf, count) < 0) { - fprintf(stderr, "%s: write error (%s)\n", - msg, strerror(errno)); - return 0; - } - - return 1; -}