From: Jeff King Date: Mon, 16 Jan 2017 21:25:35 +0000 (-0500) Subject: fsck: report trees as dangling X-Git-Tag: v2.12.0-rc0~27^2~7 X-Git-Url: https://git.lorimer.id.au/gitweb.git/diff_plain/b4584e4f665f59f51572f479db6baf1a1cdbc03a?ds=inline;hp=b4584e4f665f59f51572f479db6baf1a1cdbc03a fsck: report trees as dangling After checking connectivity, fsck looks through the list of any objects we've seen mentioned, and reports unreachable and un-"used" ones as dangling. However, it skips any object which is not marked as "parsed", as that is an object that we _don't_ have (but that somebody mentioned). Since 6e454b9a3 (clear parsed flag when we free tree buffers, 2013-06-05), that flag can't be relied on, and the correct method is to check the HAS_OBJ flag. The cleanup in that commit missed this callsite, though. As a result, we would generally fail to report dangling trees. We never noticed because there were no tests in this area (for trees or otherwise). Let's add some. Signed-off-by: Jeff King Signed-off-by: Junio C Hamano ---