From: Jeff King Date: Mon, 20 Apr 2015 19:54:03 +0000 (-0400) Subject: sha1_file: freshen pack objects before loose X-Git-Tag: v2.4.1~7^2~1 X-Git-Url: https://git.lorimer.id.au/gitweb.git/diff_plain/b5f52f372e85c6e461b6123cd7eebd544b439020?ds=inline;hp=--cc sha1_file: freshen pack objects before loose When writing out an object file, we first check whether it already exists and if so optimize out the write. Prior to 33d4221, we did this by calling has_sha1_file(), which will check for packed objects followed by loose. Since that commit, we check loose objects first. For the common case of a repository whose objects are mostly packed, this means we will make a lot of extra access() system calls checking for loose objects. We should follow the same packed-then-loose order that all of our other lookups use. Reported-by: Stefan Saasen Signed-off-by: Jeff King Signed-off-by: Junio C Hamano --- b5f52f372e85c6e461b6123cd7eebd544b439020 diff --git a/sha1_file.c b/sha1_file.c index 9711ef817d..cd6c102ccf 100644 --- a/sha1_file.c +++ b/sha1_file.c @@ -3014,7 +3014,7 @@ int write_sha1_file(const void *buf, unsigned long len, const char *type, unsign write_sha1_file_prepare(buf, len, type, sha1, hdr, &hdrlen); if (returnsha1) hashcpy(returnsha1, sha1); - if (freshen_loose_object(sha1) || freshen_packed_object(sha1)) + if (freshen_packed_object(sha1) || freshen_loose_object(sha1)) return 0; return write_loose_object(sha1, hdr, hdrlen, buf, len, 0); }