From: Johannes Schindelin Date: Mon, 9 Apr 2018 08:32:02 +0000 (+0200) Subject: t1300: `--unset-all` can leave an empty section behind (bug) X-Git-Tag: v2.18.0-rc0~100^2~7 X-Git-Url: https://git.lorimer.id.au/gitweb.git/diff_plain/b73bdc34c06358359750a896983a2ea85b694ca0 t1300: `--unset-all` can leave an empty section behind (bug) We already have a test demonstrating that removing the last entry from a config section fails to remove the section header of the now-empty section. The same can happen, of course, if we remove the last entries in one fell swoop. This is *also* a bug, and should be fixed at the same time. Signed-off-by: Johannes Schindelin Signed-off-by: Junio C Hamano --- diff --git a/t/t1300-config.sh b/t/t1300-config.sh index a59c07fcb7..8a3cd2c114 100755 --- a/t/t1300-config.sh +++ b/t/t1300-config.sh @@ -1472,6 +1472,17 @@ test_expect_failure '--unset last key removes section (except if commented)' ' test_line_count = 3 .git/config ' +test_expect_failure '--unset-all removes section if empty & uncommented' ' + cat >.git/config <<-\EOF && + [section] + key = value1 + key = value2 + EOF + + git config --unset-all section.key && + test_line_count = 0 .git/config +' + test_expect_failure 'adding a key into an empty section reuses header' ' cat >.git/config <<-\EOF && [section]