From: Rene Scharfe <l.s.r@web.de>
Date: Wed, 30 Aug 2017 17:49:46 +0000 (+0200)
Subject: help: release strbuf on error return in exec_woman_emacs()
X-Git-Tag: v2.15.0-rc0~78^2~19
X-Git-Url: https://git.lorimer.id.au/gitweb.git/diff_plain/bad0e2c6a89b52b0d6b2ebae6e290b6d4e6f799c?hp=7246218667635252395debc8eff2304592cbd587

help: release strbuf on error return in exec_woman_emacs()

Signed-off-by: Rene Scharfe <l.s.r@web.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---

diff --git a/builtin/help.c b/builtin/help.c
index 12fb48933e..b3f60a8f30 100644
--- a/builtin/help.c
+++ b/builtin/help.c
@@ -131,6 +131,7 @@ static void exec_woman_emacs(const char *path, const char *page)
 		strbuf_addf(&man_page, "(woman \"%s\")", page);
 		execlp(path, "emacsclient", "-e", man_page.buf, (char *)NULL);
 		warning_errno(_("failed to exec '%s'"), path);
+		strbuf_release(&man_page);
 	}
 }