From: Jeff King <peff@peff.net>
Date: Wed, 27 Aug 2014 07:57:08 +0000 (-0400)
Subject: date: use strbufs in date-formatting functions
X-Git-Tag: v2.2.0-rc0~119^2~2
X-Git-Url: https://git.lorimer.id.au/gitweb.git/diff_plain/c33ddc2e33d51da9391a81206a1d9e4a92d97d10?ds=inline;hp=c33ddc2e33d51da9391a81206a1d9e4a92d97d10

date: use strbufs in date-formatting functions

Many of the date functions write into fixed-size buffers.
This is a minor pain, as we have to take special
precautions, and frequently end up copying the result into a
strbuf or heap-allocated buffer anyway (for which we
sometimes use strcpy!).

Let's instead teach parse_date, datestamp, etc to write to a
strbuf. The obvious downside is that we might need to
perform a heap allocation where we otherwise would not need
to. However, it turns out that the only two new allocations
required are:

1. In test-date.c, where we don't care about efficiency.

2. In determine_author_info, which is not performance
critical (and where the use of a strbuf will help later
refactoring).

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---